Fix crash when user has 20+ direct conversations#192
Open
ESH13 wants to merge 1 commit intobasecamp:mainfrom
Open
Fix crash when user has 20+ direct conversations#192ESH13 wants to merge 1 commit intobasecamp:mainfrom
ESH13 wants to merge 1 commit intobasecamp:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
find_direct_placeholder_usersinUsers::SidebarsControllerpasses a negative value to.limit()when a user has direct rooms with 20 or more unique participants. PostgreSQL raisesLIMIT must not be negative, crashing the sidebar controller. Since the sidebar is loaded via a Turbo Frame on every page, this makes the entire application unusable for that user — "Content missing" on every page, every browser, every device.Fix
Clamp the limit to a minimum of zero so
limit(0)returns an empty result set instead of raising. One-line change.See #191